HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36258 )
Change subject: cpu/amd/*/*/acpi/: Use 'Device()' instead of 'Processor()'
......................................................................
Patch Set 4:
Patch Set 3: Code-Review-1
Please don't merge, I'm waiting for an answer
I think that PBlk is not needed at all
Please see "AMD OpteronTM A1100 Series Processor ACPI Porting Guide" page 23 for an example.
I also got the answer from acpica team. Here is the answer from Erik Schmauss:
"Yeah, we dug around the change logs to see a reasoning on why processor was replaced by device there was no explanation given for these fields so I think it’s safe to assume that there isn’t a need for these parameters…"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36258
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4541372a98f05d3e915c74bc28f41309754014e4
Gerrit-Change-Number: 36258
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Oct 2019 19:02:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment