build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )
Change subject: nb/intel: Introduce MCHBAR accessor functions ......................................................................
Patch Set 38:
(16 comments)
File src/northbridge/intel/common/mchbar_ops.h:
https://review.coreboot.org/c/coreboot/+/45517/comment/8ab70c49_47e4fcfb PS38, Line 39: #define mchbar16_and_or(offset, mask, value) _mchbar16_and_or((offset), (u16)(mask), (u16)(value)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45517/comment/52f5223d_3ce8caca PS38, Line 51: #define mchbar32_and_or(offset, mask, value) _mchbar32_and_or((offset), (u32)(mask), (u32)(value)) line over 96 characters
File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45517/comment/52a1c9f4_3180b564 PS38, Line 344: <<<<<<< HEAD spaces required around that '<' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/45517/comment/bdc55e5e_b378af98 PS38, Line 349: ======= spaces required around that '==' (ctx:ExO)
https://review.coreboot.org/c/coreboot/+/45517/comment/be179a79_585a15de PS38, Line 349: ======= spaces required around that '==' (ctx:OxO)
https://review.coreboot.org/c/coreboot/+/45517/comment/1d150902_76b77c43 PS38, Line 349: ======= spaces required around that '==' (ctx:OxO)
https://review.coreboot.org/c/coreboot/+/45517/comment/fe94d3ea_a04034a6 PS38, Line 349: ======= spaces required around that '=' (ctx:OxE)
https://review.coreboot.org/c/coreboot/+/45517/comment/62848010_5c7a8626 PS38, Line 350: >>>>>>> 7780462203 (nb/intel: Introduce MCHBAR accessor functions) spaces required around that '>' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/45517/comment/fbd17ed8_54361a17 PS38, Line 350: >>>>>>> 7780462203 (nb/intel: Introduce MCHBAR accessor functions) spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/45517/comment/ea726ff0_01c211cf PS38, Line 379: <<<<<<< HEAD spaces required around that '<' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/45517/comment/b1f2b6f4_d5e08e1b PS38, Line 384: ======= spaces required around that '==' (ctx:ExO)
https://review.coreboot.org/c/coreboot/+/45517/comment/497bf978_7a92d0a2 PS38, Line 384: ======= spaces required around that '==' (ctx:OxO)
https://review.coreboot.org/c/coreboot/+/45517/comment/a375bdc0_5f0635fb PS38, Line 384: ======= spaces required around that '==' (ctx:OxO)
https://review.coreboot.org/c/coreboot/+/45517/comment/ff68b83c_e9f12309 PS38, Line 384: ======= spaces required around that '=' (ctx:OxE)
https://review.coreboot.org/c/coreboot/+/45517/comment/25b00fee_08288ddc PS38, Line 385: >>>>>>> 7780462203 (nb/intel: Introduce MCHBAR accessor functions) spaces required around that '>' (ctx:OxW)
https://review.coreboot.org/c/coreboot/+/45517/comment/7fe56a15_c0413aa0 PS38, Line 385: >>>>>>> 7780462203 (nb/intel: Introduce MCHBAR accessor functions) spaces required around that ':' (ctx:VxW)