Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49892 )
Change subject: cpu/x86/smm: Remove unused APMC for C-state and P-state ......................................................................
cpu/x86/smm: Remove unused APMC for C-state and P-state
Change-Id: I7a3a1b63c0ef14b1e24ecce2df66f7970e5eb669 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49892 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/cpu/x86/smm/smi_trigger.c M src/include/cpu/x86/smm.h 2 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/cpu/x86/smm/smi_trigger.c b/src/cpu/x86/smm/smi_trigger.c index ff5eeae..e4c6dc9 100644 --- a/src/cpu/x86/smm/smi_trigger.c +++ b/src/cpu/x86/smm/smi_trigger.c @@ -7,12 +7,6 @@ static void apmc_log(const char *fn, u8 cmd) { switch (cmd) { - case APM_CNT_CST_CONTROL: - printk(BIOS_DEBUG, "%s: C-state control.\n", fn); - break; - case APM_CNT_PST_CONTROL: - printk(BIOS_DEBUG, "%s: P-state control.\n", fn); - break; case APM_CNT_ACPI_DISABLE: printk(BIOS_DEBUG, "%s: Disabling ACPI.\n", fn); break; diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index 31827cf..cd83bdf 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -18,8 +18,6 @@
#define APM_CNT 0xb2 #define APM_CNT_NOOP_SMI 0x00 -#define APM_CNT_CST_CONTROL 0x85 -#define APM_CNT_PST_CONTROL 0x80 #define APM_CNT_ACPI_DISABLE 0x1e #define APM_CNT_ACPI_ENABLE 0xe1 #define APM_CNT_ROUTE_ALL_XHCI 0xca