[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add vboot callbacks to support EC software sync

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )

Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................

Patch Set 18:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36208/17/src/security/vboot/ec_sync... 
File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36208/17/src/security/vboot/ec_sync... 
PS17, Line 268: (burst / resp_flash.write_block_size) *
              : 		resp_flash.write_block_size;
> > Doesn't that mean that resp_flash.write_block_size must be a power of two?   […]

Depthcharge never made this assumption, and even though this does save a multiply and a divide that have a RAW dependency, it's only called once per boot.  Hmm, but it's probably a safe assumption that Flash will always use power-of-2 sized pages... Unless you feel strongly about this, I'd rather leave it this way.