[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/nissa/var/nivviks: Update the power resource for NVM and VCM

[V Sowmya (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.

V Sowmya has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/84420?usp=email )

Change subject: mb/google/nissa/var/nivviks: Update the power resource for NVM and VCM
......................................................................

Patch Set 2:

(3 comments)

File src/mainboard/google/brya/variants/nivviks/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/84420/comment/29b4b938_9c3ee4cd?usp... :
PS1, Line 512: 			chip drivers/sof
             : 				register "spkr_tplg" = "max98360a"
             : 				register "jack_tplg" = "nau8825"
             : 				register "mic_tplg" = "_2ch_pdm0"
             : 				device generic 0 on end
             : 			end
> why you have removed this code ?

Apologies for oversight and i have reverted the change.

https://review.coreboot.org/c/coreboot/+/84420/comment/ac159435_077e0a9b?usp... :
PS1, Line 449: E(1, 0)"
> SEQ_OPS_GPIO_DISABLE(0, 0)

Off/Disable sequence is gpio[1] -> gpio[0] (Its done in same sequence for camera sensor also)

https://review.coreboot.org/c/coreboot/+/84420/comment/3412876f_00031d6c?usp... :
PS1, Line 450:  "SEQ_OPS_GPIO_DISABLE(0, 0)"
> "SEQ_OPS_GPIO_DISABLE(1, 0)"

Off/Disable sequence is gpio[1] -> gpio[0]