Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43851 )
Change subject: skylake boards: Factor out copy-pasted PIRQ routes
......................................................................
Patch Set 2:
Patch Set 1:
(1 comment)
Just a note, that on the KBL-U board [1], Linux does not list IRQ 11 in `/proc/interrupts` with the vendor firmware.
You would have to disable APICs (and I guess SMP) to make use of these PIRQ routes.
Sorry for being ignorant. Just wanted to note, that the vendor firmware does not expose it, but with coreboot Linux says, an IRQ 11 was received. (The port is work in progress, though it might be unrelated.)
[1]: https://review.coreboot.org/c/coreboot/+/43760/12#message-ba4420a9135b2f3f28...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief526efcbd5ba5546572da1bc6bb6d86729f4e54
Gerrit-Change-Number: 43851
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Jul 2020 11:19:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment