Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/21587
Change subject: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection ......................................................................
mb/lenovo/x2?0/devicetree: Fix regression of BDC detection
The x220 and x230 do have BDC detection, but it's broken. Disable BDC detection on those two boards, and add a comment why it doesn't work.
The issue has been reported and tested on Lenovo X220.
Change-Id: Id1ccc2c4387370e284ff8964e1c41d945cefe74c Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x230/devicetree.cb 2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/21587/1
diff --git a/src/mainboard/lenovo/x220/devicetree.cb b/src/mainboard/lenovo/x220/devicetree.cb index 1332cd8..2aa2431 100644 --- a/src/mainboard/lenovo/x220/devicetree.cb +++ b/src/mainboard/lenovo/x220/devicetree.cb @@ -165,7 +165,9 @@ register "eventd_enable" = "0xff" register "evente_enable" = "0x0d"
- register "has_bdc_detection" = "1" + # BDC detection is broken on this board as pin14 of + # the BDC's connector is left floating. + register "has_bdc_detection" = "0" register "bdc_gpio_num" = "54" register "bdc_gpio_lvl" = "0" end diff --git a/src/mainboard/lenovo/x230/devicetree.cb b/src/mainboard/lenovo/x230/devicetree.cb index d7f5647..b2527c4 100644 --- a/src/mainboard/lenovo/x230/devicetree.cb +++ b/src/mainboard/lenovo/x230/devicetree.cb @@ -167,7 +167,9 @@ register "eventd_enable" = "0xff" register "evente_enable" = "0x0d"
- register "has_bdc_detection" = "1" + # BDC detection is broken on this board as pin14 of + # the BDC's connector is left floating. + register "has_bdc_detection" = "0" register "bdc_gpio_num" = "54" register "bdc_gpio_lvl" = "0" end