Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 )
Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants/... PS2, Line 250: case SKU_0_EKKO: : case SKU_1_EKKO: : case SKU_2_EKKO: : case SKU_3_EKKO: : case SKU_0_BARD: : case SKU_1_BARD: : case SKU_2_BARD: : case SKU_3_BARD: : pl2_id = PL2_ID_BARD_EKKO;
If port 5 needs to be disabled for these skus, then you will have to put this above case SKU_0_VAYNE […]
bard&ekko SKU ids should not be same as Vaye&Panthon suppose that ekko&bard sku can be set and will not break in vayne&pathon case?