Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56925 )
Change subject: mb/google/guybrush: update USB 2.0 Lane Parameter settings for USB port5 ......................................................................
mb/google/guybrush: update USB 2.0 Lane Parameter settings for USB port5
Tune the USB phy settings to update TXVREFTUNE0/COMPDISTUNE0 to higher value for USB port 5 (Type-A).
BUG=b:194053549 TEST= Pass USB 2.0 SI Eye diagram measurement.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: Id1ede34bdbee0c1f9f7d10fc7ffbc9648af31e3e Reviewed-on: https://review.coreboot.org/c/coreboot/+/56925 Reviewed-by: Rob Barnes robbarnes@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Rob Barnes: Looks good to me, approved
diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index f9a1201..c707c0f 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -118,13 +118,13 @@ .txrestune = 1, }, .Usb2PhyPort[5] = { - .compdstune = 3, + .compdstune = 5, .sqrxtune = 3, .txfslstune = 3, .txpreempamptune = 1, .txpreemppulsetune = 0, .txrisetune = 1, - .txvreftune = 6, + .txvreftune = 9, .txhsxvtune = 3, .txrestune = 1, },