Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31911 )
Change subject: resources: introduce io_resource() ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31911/1/src/device/device_util.c File src/device/device_util.c:
https://review.coreboot.org/#/c/31911/1/src/device/device_util.c@811 PS1, Line 811: resource->base = (resource_t)basek; The 'k' in basek an sizek refers to the unit counting in KiB. Remove.
https://review.coreboot.org/#/c/31911/1/src/device/device_util.c@817 PS1, Line 817: resource->flags |= type; Not sure if there are any additional flags to use with IO resources. Maybe you don't have to pass the type parameter at all.