Kenneth Chan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60238 )
Change subject: mb/google/guybrush/var/dewatt: update USB 2.0 Lane Parameter settings for USB ports ......................................................................
mb/google/guybrush/var/dewatt: update USB 2.0 Lane Parameter settings for USB ports
Tune the USB phy settings to update txpreempamptune to 3 and txpreempamptune to 6 for passing USB 2.0 SI Eye diagram measurement (port 0/1/4).
BUG=b:199468920 TEST= emerge-guybrush coreboot; pass USB 2.0 SI Eye diagram measurement.
Signed-off-by: Kenneth Chan kenneth.chan@quanta.corp-partner.google.com Change-Id: I8d82a327fb6e4e69abe335be0bb4619021662e79 --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M 3rdparty/qc_blobs M src/mainboard/google/guybrush/variants/dewatt/overridetree.cb 5 files changed, 44 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/60238/1
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index f638765..87ff88e 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit f638765f17cdca735b69229f4f0479562bcb7526 +Subproject commit 87ff88e5ff7eefa5d1b895ff7be115ae5f0fc55f diff --git a/3rdparty/blobs b/3rdparty/blobs index b8e3eaf..1a86592 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit b8e3eaf7501aaa234e93a4a305bf711cf34bb0ad +Subproject commit 1a86592b1652c11a2718511583b8a3c211aabe05 diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 3f97690..ee319ae 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 3f97690f0da8011f52209b232450a1e5c4f2e1f6 +Subproject commit ee319ae7bc59e88b60142f40a9ec1b46656de4db diff --git a/3rdparty/qc_blobs b/3rdparty/qc_blobs index 98db386..826cb9c 160000 --- a/3rdparty/qc_blobs +++ b/3rdparty/qc_blobs @@ -1 +1 @@ -Subproject commit 98db38671b651dd7e7966fb629d65ff5dd23865b +Subproject commit 826cb9c6343d439f547837c342e8c349dab1fa77 diff --git a/src/mainboard/google/guybrush/variants/dewatt/overridetree.cb b/src/mainboard/google/guybrush/variants/dewatt/overridetree.cb index 9366ea6..f3fd0e6 100644 --- a/src/mainboard/google/guybrush/variants/dewatt/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/dewatt/overridetree.cb @@ -18,6 +18,46 @@ register "telemetry_vddcrsocfull_scale_current_mA" = "30314" #mA register "telemetry_vddcrsocoffset" = "560"
+ #USB 2.0 phy config + register "usb_phy" = "{ + /* Left USB C0 Port */ + .Usb2PhyPort[0] = { + .compdstune = 3, + .sqrxtune = 3, + .txfslstune = 3, + .txpreempamptune = 3, + .txpreemppulsetune = 0, + .txrisetune = 1, + .txvreftune = 6, + .txhsxvtune = 3, + .txrestune = 1, + }, + /* Left USB A0 Port */ + .Usb2PhyPort[1] = { + .compdstune = 3, + .sqrxtune = 3, + .txfslstune = 3, + .txpreempamptune = 3, + .txpreemppulsetune = 0, + .txrisetune = 1, + .txvreftune = 6, + .txhsxvtune = 3, + .txrestune = 1, + }, + /* Right USB C1 Port */ + .Usb2PhyPort[4] = { + .compdstune = 3, + .sqrxtune = 3, + .txfslstune = 3, + .txpreempamptune = 3, + .txpreemppulsetune = 0, + .txrisetune = 1, + .txvreftune = 6, + .txhsxvtune = 3, + .txrestune = 1, + }, + }" + # I2C Config #+-------------------+---------------------------+ #| Field | Value |