14 Jan
2021
14 Jan
'21
3:56 p.m.
Attention is currently required from: Jonathan Zhang, Jingle Hsu. Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39979 )
Change subject: intel/xeon_sp: add ACPI to control GPIO ......................................................................
Patch Set 43:
(3 comments)
Patchset:
PS43: Thanks for review and testing
File src/soc/intel/xeon_sp/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39979/comment/70b96c94_e7d6ab94 PS41, Line 19: Memory32Fixed (ReadWrite, 0, 0, COM1)
When resource/_CRS not for com2, […]
COM2 has been added in the patch-set 42.
https://review.coreboot.org/c/coreboot/+/39979/comment/e9a3a74b_054746e0 PS41, Line 82: GPP_H23
Out of community 1 range.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/39979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07c882077eb3c035faae81641bc860e69db224b4
Gerrit-Change-Number: 39979
Gerrit-PatchSet: 43
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam anjaneya.chagam@intel.com
Gerrit-Reviewer: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Marc Jones marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Jonathan Zhang jonzhang@fb.com
Gerrit-Attention: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-Comment-Date: Thu, 14 Jan 2021 15:56:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-MessageType: comment