Attention is currently required from: Tim Wawrzynczak, Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58230 )
Change subject: mb/google/wyvern: use SaGv_FixedHigh
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/hatch/variants/wyvern/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58230/comment/62afee4b_07e1db80
PS1, Line 23: # Enable System Agent fixed frequency
Why not explain the reasoning instead, as done in the commit message?
I'm not sure how to condense that into 1-2 lines neatly. Suggestions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58230
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ad773d1c616b746235ec67b98b83c5910464140
Gerrit-Change-Number: 58230
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 11 Oct 2021 20:36:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment