Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )
Change subject: soc/amd/picasso: Add northbridge pci driver ......................................................................
Patch Set 29: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/34424/28/src/soc/amd/picasso/northb... File src/soc/amd/picasso/northbridge.c:
https://review.coreboot.org/c/coreboot/+/34424/28/src/soc/amd/picasso/northb... PS28, Line 70: TOM1 Just curious - how do these get used from ACPI? Is it used by static asl code? Or is it the kernel using it?
https://review.coreboot.org/c/coreboot/+/34424/28/src/soc/amd/picasso/northb... PS28, Line 75: http://www.acpi.info/presentations/S01USMOBS169_OS%2520new.ppt This link is not really accessible?