[coreboot-gerrit] [M] Change in coreboot[master]: UNTESTED acpi: Add ECAM region below PNP0C02 device in SSDT

[Arthur Heymans (Code Review)]

Attention is currently required from: Angel Pons, Jeff Daly, Lance Zhao, Matt DeVillier, Nico Huber, Sean Rhodes, Tim Wawrzynczak, Vanessa Eusebio.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75729?usp=email )

Change subject: UNTESTED acpi: Add ECAM region below PNP0C02 device in SSDT
......................................................................

Patch Set 2:

(2 comments)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/75729/comment/3435b5ea_ffebb96d :
PS2, Line 587: 	struct device *dev = dev_find_path(NULL, DEVICE_PATH_DOMAIN);
             : 	assert(dev != NULL);
> We could also export domain devices to `build/static_devices.h`.
>
> OTOH, filtering the right device in the loop device should do too.

On some upcoming, not yet upstream AMD platform I use domain numbers to match an ID on the data fabric. That would make static_devices.h harder to use.

https://review.coreboot.org/c/coreboot/+/75729/comment/456f085a_acfb67c4 :
PS2, Line 594: 1
> Shouldn't this be unique (I'm not sure about the scope)? i.e. not the same
> as in the static `.asl` files.

I tried to find a device name not found in DSDT and just set _UID to 1 without a particular reason (probably copied from existing DSDT)