Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37895 )
Change subject: arch/x86: Top align bootblock program ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... PS2, Line 33: *(.bootblock.top); The FIT table is also sitting within the last 4KiB. How are we ensuring we aren't packing things in that will collide?
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... PS2, Line 37: 16 What are the 16 bytes for?
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... PS2, Line 38: EARLYASM_SZ = (_erealmode - _realmode + 16) + (CONFIG(SIPI_VECTOR_IN_ROM) ? 4096 : 0); What are we trying to calculate? A comment would be helpful.
https://review.coreboot.org/c/coreboot/+/37895/2/src/cpu/x86/16bit/reset16.l... PS2, Line 45: 0xf0 I'm not following this sequence either. I think there needs some more explanation.