[coreboot-gerrit] [S] Change in coreboot[master]: arch/arm64: Hook up ACPI table generation

[Julius Werner (Code Review)]

Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Nico Huber.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76071?usp=email )

Change subject: arch/arm64: Hook up ACPI table generation
......................................................................

Patch Set 4:

(2 comments)

File src/arch/arm64/Kconfig:

https://review.coreboot.org/c/coreboot/+/76071/comment/cdd08a8d_2d6753c8 :
PS4, Line 61: config MAX_ACPI_TABLE_SIZE_KB
I think this needs to be moved to some platform-independent place (e.g. src/acpi/Kconfig) if you want to use it here as well.

File src/arch/arm64/tables.c:

https://review.coreboot.org/c/coreboot/+/76071/comment/54fe7648_41a2a534 :
PS4, Line 18: 		printk(BIOS_ERR, "Increase ACPI size\n");
I see that this is the same as what x86 already does, but this is a truly terrible API. We're running straight over other CBMEM spaces and this isn't even an assert(), just a BIOS_ERR print. Can we (in a separate patch effort) fix write_acpi_tables() to actually take an upper bound and respect it?