Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46916 )
Change subject: cpu/intel/haswell: Enable timed MWAIT if supported
......................................................................
Patch Set 16:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/46916/comment/0b7f5e5d_9e9742f5
PS16, Line 9: unconditionally enables it
I don't see any unconditional enablement that you remove, just an addition to enable it if it's supp […]
The specific line that I refer to is: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/broadwell/c...
I guess the commit message may not make much sense without considering the context (backporting Broadwell things to Haswell).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46916
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d11d62f1801d65ae4d5623994fd55fd35e8f34a
Gerrit-Change-Number: 46916
Gerrit-PatchSet: 16
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 Jan 2021 11:55:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment