Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42224 )
Change subject: soc/amd/common/blocks/gpio: Introduce gpio_get_bar ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42224/6/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/42224/6/src/soc/amd/common/block/ac... PS6, Line 65: return (void *)ACPIMMIO_GPIO0_BASE; This should be cast through a uintptr_t.
https://review.coreboot.org/c/coreboot/+/42224/6/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42224/6/src/soc/amd/common/block/gp... PS6, Line 184: inter_master = gpio_get_bar() + GPIO_MASTER_SWITCH; fwiw, we shouldn't be doing arithmetic on void * pointers.
https://review.coreboot.org/c/coreboot/+/42224/6/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/gpio_banks.h:
https://review.coreboot.org/c/coreboot/+/42224/6/src/soc/amd/common/block/in... PS6, Line 281: gpio_get_bar gpio_get_bar is function, correct? use gpio_get_bar()
https://review.coreboot.org/c/coreboot/+/42224/6/src/soc/amd/common/block/in... PS6, Line 281: 4) sizeof(uint32_t)