Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 )
Change subject: src/device: Add MDIO operation ......................................................................
Patch Set 2:
(3 comments)
File src/device/mdio.c:
https://review.coreboot.org/c/coreboot/+/69382/comment/a13bfece_7c2bed60 PS1, Line 11: operations.
Please add a '\n' here for a proper line break.
Done
https://review.coreboot.org/c/coreboot/+/69382/comment/31b52053_6e02cacd PS1, Line 11: mdio
Shall we spell it upper case in log messages?
Ack
File src/include/device/mdio.h:
https://review.coreboot.org/c/coreboot/+/69382/comment/81add89c_3dda2af0 PS1, Line 6: struct device;
You should include <device/device.h> here and avoid the forward declaration of 'struct device' […]
<device/device.h> is allready in mdio.c then I can remove the include from mdio.c, right?