[coreboot-gerrit] [L] Change in coreboot[main]: soc/intel/common/block/imc: Add Integrated Memory Controller driver

[Shuo Liu (Code Review)]

Attention is currently required from: Felix Singer, Jérémy Compostella, [e-mail].

Shuo Liu has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )

Change subject: soc/intel/common/block/imc: Add Integrated Memory Controller driver
......................................................................

Patch Set 15:

(2 comments)

File src/soc/intel/common/block/smbus/smbuslib.c:

https://review.coreboot.org/c/coreboot/+/83320/comment/e7a5c4d8_4ed18b98?usp... :
PS15, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
maybe you can add a separate patch to rename smbuslib.c to spdlib.c, and to rename spd.c to spd_access.c

https://review.coreboot.org/c/coreboot/+/83320/comment/bbad2b99_9f502af0?usp... :
PS15, Line 9: __weak int spd_read_byte(u8 slave_addr, u8 bus_addr)
no need to have week here