Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47442 )
Change subject: vc/google/chromeos/sar: Make "SAR not found" log a debug message ......................................................................
vc/google/chromeos/sar: Make "SAR not found" log a debug message
coreboot might not store wifi SAR values in VPD and may store it in CBFS. Logging the message with 'error' severity may interfere with automated test tool.
Lowering severity to BIOS_DEBUG avoids this issue.
BUG=b:171931401 BRANCH=None TEST=Severity of message is reduced and we don't see it as an error
Change-Id: I5c122a57cfe92b27e0291933618ca13d8e1889ba Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47442 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/drivers/wifi/generic/acpi.c M src/vendorcode/google/chromeos/sar.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index cd5af4e..4440b81 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -53,7 +53,7 @@
/* Retrieve the sar limits data */ if (get_wifi_sar_limits(&sar_limits) < 0) { - printk(BIOS_ERR, "Error: failed from getting SAR limits!\n"); + printk(BIOS_DEBUG, "failed from getting SAR limits!\n"); return; }
diff --git a/src/vendorcode/google/chromeos/sar.c b/src/vendorcode/google/chromeos/sar.c index 2f73d39..9bca423 100644 --- a/src/vendorcode/google/chromeos/sar.c +++ b/src/vendorcode/google/chromeos/sar.c @@ -71,7 +71,7 @@ /* Try to read the SAR limit entry from VPD */ if (!vpd_gets(wifi_sar_limit_key, wifi_sar_limit_str, buffer_size, VPD_RO_THEN_RW)) { - printk(BIOS_ERR, "Error: Could not locate '%s' in VPD.\n", + printk(BIOS_DEBUG, "Could not locate '%s' in VPD.\n", wifi_sar_limit_key);
if (!CONFIG(WIFI_SAR_CBFS))