Attention is currently required from: Paul Menzel, Nikolai Vyssotski, Felix Held.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )
Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48734/comment/03c2dbd1_4b6b9724
PS5, Line 30: register "edp_table_size" = "0x05"
After talking to Eddie and looking at VBIOS spec it does appear that 5 is correct. […]
had remove the dp_sel and tablesize and dp version. only keep the dp override type. will clean up the related UPD in later changeing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe720e26d2257e05a989eaa1fd85d542005cf6a6
Gerrit-Change-Number: 48734
Gerrit-PatchSet: 8
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 21 Jan 2021 19:06:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment