Attention is currently required from: YH Lin, Tarun Tuli, Subrata Banik, Kapil Porwal.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74257 )
Change subject: rex: add variant gpio tables for variant creation
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rex/variants/baseboard/rex/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74257/comment/f69f7e5f_c4c6ba9a
PS2, Line 4: romstage-y += gpio.c
you miss the ramstage-y += gpio.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebc098f8d480ac3e1835b00861fd844d97f281a8
Gerrit-Change-Number: 74257
Gerrit-PatchSet: 2
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Tue, 11 Apr 2023 03:37:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment