Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Christian Walter.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61720 )
Change subject: drivers/i2c/tpm/cr50: Add support to get cr50 firmware version
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/61720/comment/79648304_d74ee156
PS3, Line 503: 301
I see this is the same as in the spi version. Does CR50 allocate 300 bytes for its version field? Spi code also doesn't mention where this value comes from.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61720
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dbdbc6ec717f1aa89111ae09249cbe2312054d9
Gerrit-Change-Number: 61720
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Tue, 08 Feb 2022 23:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment