Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37838 )
Change subject: cbfs: Do not use vboot_locator in bootblock with separate verstage
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37838/1/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/37838/1/src/lib/cbfs.c@305
PS1, Line 305: #if CONFIG(VBOOT) && !(ENV_BOOTBLOCK && CONFIG(VBOOT_SEPARATE_VERSTAGE))
If you are using VBOOT_RETURN_FROM_VERSTAGE then this change is incorrect as you need to steer corre […]
Thanks for the feedback. But just realized I also need to enable VBOOT_RETURN_FROM_VERSTAGE so this actually won't help my problem...
I'll abandon this one and think about other approaches to reduce size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37838
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id17cd151b4426231704b1c9845348763126a7870
Gerrit-Change-Number: 37838
Gerrit-PatchSet: 1
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ting Shen
phoenixshen@google.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 20 Dec 2019 00:50:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment