4 Jun
2019
4 Jun
'19
8:39 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33211 )
Change subject: nb/amd/amdmct/mct: Deduplicate conditional ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Looks wrong to me.
https://review.coreboot.org/#/c/33211/1/src/northbridge/amd/amdmct/mct/mctar... File src/northbridge/amd/amdmct/mct/mctardk3.c:
https://review.coreboot.org/#/c/33211/1/src/northbridge/amd/amdmct/mct/mctar... PS1, Line 102: How do you know pDCTstat->Speed isn't 4?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33211
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41aa19b4b7ed7b1a0e4f83f72e66869760e677dd
Gerrit-Change-Number: 33211
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 04 Jun 2019 18:39:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment