Attention is currently required from: EricR Lai. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57016 )
Change subject: mb/google/brya: Add ALC1019_NAU88L25B support ......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57016/comment/dff8bc10_ce5a4281 PS1, Line 219: register "short_key_debounce" = "2" # 100ms : register "jack_insert_debounce" = "7" # 512ms : register "jack_eject_debounce" = "7" # 512ms
yes, HP is functional as well.
Please update the commit message next time.
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57016/comment/78da8a5c_57e289a7 PS2, Line 207: register "jkdet_polarity" = "1" # ActiveLow : register "vref_impedance" = "2" # 125kOhm : register "micbias_voltage" = "6" # 2.754 : register "sar_threshold_num" = "4" : register "sar_threshold[0]" = "0x0c" : register "sar_threshold[1]" = "0x1c" : register "sar_threshold[2]" = "0x38" : register "sar_threshold[3]" = "0x60" : register "sar_hysteresis" = "1" : register "sar_voltage" = "0" # VDDA : register "sar_compare_time" = "0" # 500ns : register "sar_sampling_time" = "0" # 2us : register "short_key_debounce" = "2" # 100ms : register "jack_insert_debounce" = "7" # 512ms : register "jack_eject_debounce" = "7" # 512ms Id3eb18cae2dd9a7b148bc9f3dcaf387f35dbd2fb (CB:57071) fixes the alignment. Please make sure to use an editor which correctly copies tabs.
https://review.coreboot.org/c/coreboot/+/57016/comment/34788842_e53719fb PS2, Line 227: register "hid" = ""RTL1019"" Why is this HID chosen, if everywhere else ALC1019 is written?