Attention is currently required from: Hung-Te Lin.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62065 )
Change subject: src/mediatek/mt8186: Get dram size from mtk ddr info or CBMEM_ID_MEMINFO
......................................................................
Patch Set 17: Verified+1
(1 comment)
File src/soc/mediatek/mt8186/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144160):
https://review.coreboot.org/c/coreboot/+/62065/comment/afdf8d3b_09176fe9
PS17, Line 29: for (unsigned int i = 0; i < mc->num_channels; ++i) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I017e9d1a2d6e26f1fc21b67b5962dfb5c6ade8a5
Gerrit-Change-Number: 62065
Gerrit-PatchSet: 17
Gerrit-Owner: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Thu, 17 Mar 2022 05:54:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment