Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75903?usp=email )
Change subject: acpi/acpi.c: Return function argument when bailing out ......................................................................
acpi/acpi.c: Return function argument when bailing out
Returning a constant value makes the function easier to read and think about.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: Ifdf7acec38a7c958aac2cf1f3bbf16c27fa90b8c --- M src/acpi/acpi.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/75903/1
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 9b4dafa..d8988ea 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1931,7 +1931,7 @@ dsdt_file = cbfs_map(CONFIG_CBFS_PREFIX "/dsdt.aml", &dsdt_size); if (!dsdt_file) { printk(BIOS_ERR, "No DSDT file, skipping ACPI tables\n"); - return current; + return start; }
if (dsdt_file->length > dsdt_size @@ -1939,7 +1939,7 @@ || memcmp(dsdt_file->signature, "DSDT", 4) != 0) { printk(BIOS_ERR, "Invalid DSDT file, skipping ACPI tables\n"); cbfs_unmap(dsdt_file); - return current; + return start; }
slic_file = cbfs_map(CONFIG_CBFS_PREFIX "/slic", &slic_size);