Attention is currently required from: Jason Glenesk, Matt DeVillier, Eric Lai, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72860 )
Change subject: soc/amd/picasso/soc_util: use cpuid_match
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/72860/comment/00745f69_8ebd4e6c
PS4, Line 97: 0xffffff00
create another mask for this?
that would be good, but i didn't find a good name for this mask. CPUID_ALL_STEPPINGS_ALL_BASE_MODELS_MASK maybe?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62
Gerrit-Change-Number: 72860
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 07 Feb 2023 08:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment