Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42373 )
Change subject: mainboard/hp: Add ProBook 6360b ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42373/2/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/6360b/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42373/2/src/mainboard/hp/snb_ivb_la... PS2, Line 38: register "ec_data_port" = "0x60" : register "ec_cmd_port" = "0x64" : register "ec_ctrl_reg" = "0xca" : register "ec_fan_ctrl_value" = "0x6e" : device pnp ff.1 off end
Weird. Maybe the EC firmware isn't the same.
I don't know how exactly this value works, and the KBC1126 code in coreboot is a small part of the EC support code from the HP firmware, so bugs can happen. I've seen fan control problems on cold boots in 8560w/8760w (both workstation boards are WIP and I don't have them currently). Yes, the script is out-of-date for newer r2 versions...