Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43305 )
Change subject: tests: Add lib/memrange-test test case ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43305/3/tests/lib/memrange-test.c File tests/lib/memrange-test.c:
https://review.coreboot.org/c/coreboot/+/43305/3/tests/lib/memrange-test.c@3... PS3, Line 31: struct device mem_device_mock[] = { You have a nice memory map in the next CL (for bootmem-test.c). Can you do something similar here so that the reader can more quickly see what you're setting up and why?
https://review.coreboot.org/c/coreboot/+/43305/3/tests/lib/memrange-test.c@3... PS3, Line 36: static void test_memrange_basic(void **state) It would be good to have 1 or 2 sentences describing what each of these tests are verifying.
https://review.coreboot.org/c/coreboot/+/43305/3/tests/lib/memrange-test.c@6... PS3, Line 66: /* Remove initial memrange */ What are you verifying here? That memranges_teardown will leave no entries? That might be better as its own test, instead of being included in one of these tests.