[coreboot-gerrit] Change in coreboot[master]: soc/intel/fsp_baytrail: use designware I2C driver

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36062 )

Change subject: soc/intel/fsp_baytrail: use designware I2C driver
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36062/5/src/soc/intel/fsp_baytrail/... 
File src/soc/intel/fsp_baytrail/i2c.c:

https://review.coreboot.org/c/coreboot/+/36062/5/src/soc/intel/fsp_baytrail/... 
PS5, Line 83: if (!tree_dev || !tree_dev->enabled) {
> I would change the logic here to && otherwise you can end up dereferencing a NULL pointer for "tree_ […]

Ups, my bad. You can keep it as it is because if tree_dev is 0 "!tree_dev" will evaluate to "non-zero" and the second part of the OR will even not be checked.

https://review.coreboot.org/c/coreboot/+/36062/5/src/soc/intel/fsp_baytrail/... 
PS5, Line 90: !config || !config->early_init
> Same here

Here as well.