Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31979 )
Change subject: soc/nvidia/tegra{124,210}: Remove unneeded 'include <halt.h>'
......................................................................
Patch Set 3:
Hmm, we know the architecture... so we could
`-include .../stdint.h` directly, I guess? Instead of
adding the coreboot include path.
Yeah, that might be a good idea. The arch include path is already hardcoded in the Makefile anyway, may as well hardcode the file. (Alternatively we could also just directly define the 3 types it uses.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a67abb77846172597b8ebde779878b9aa2ff8d7
Gerrit-Change-Number: 31979
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:52:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment