Isaac Christensen (isaac.christensen@se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6505
-gerrit
commit c6d5a4e1e93b633f00dfc00a1f1e2f3972b4aa24 Author: Stefan Reinauer reinauer@chromium.org Date: Wed Aug 14 17:14:39 2013 -0700
Exynos5: Remove unneeded USB delays
Change-Id: I1144e9d6d6c4278842fdd36743c8a88555f81707 Signed-off-by: Stefan Reinauer reinauer@google.com Reviewed-on: https://gerrit.chromium.org/gerrit/65912 Reviewed-by: Ronald G. Minnich rminnich@chromium.org Commit-Queue: Stefan Reinauer reinauer@chromium.org Tested-by: Stefan Reinauer reinauer@chromium.org (cherry picked from commit 95b518877edc88347ce9725ffee32f3aed0de7dc) Signed-off-by: Isaac Christensen isaac.christensen@se-eng.com --- src/cpu/samsung/exynos5250/usb.c | 9 +++++---- src/cpu/samsung/exynos5420/usb.c | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/cpu/samsung/exynos5250/usb.c b/src/cpu/samsung/exynos5250/usb.c index d8e07da..5084707 100644 --- a/src/cpu/samsung/exynos5250/usb.c +++ b/src/cpu/samsung/exynos5250/usb.c @@ -88,10 +88,11 @@ static void setup_usb_phy(struct usb_phy *usb, int hsic_gpio) udelay(10); clrbits_le32(&usb->hsicphyctrl1, HOST_CTRL0_PHYSWRST);
- /* PHY clock and power setup time */ - // FIXME If this happens more than 50ms before executing the payload, - // we might not need this delay. - mdelay(50); + /* At this point we need to wait for 50ms before talking to + * the USB controller (PHY clock and power setup time) + * By the time we are actually in the payload, these 50ms + * will have passed. + */ }
void usb_init(device_t dev) diff --git a/src/cpu/samsung/exynos5420/usb.c b/src/cpu/samsung/exynos5420/usb.c index 4d07699..6e79ef1 100644 --- a/src/cpu/samsung/exynos5420/usb.c +++ b/src/cpu/samsung/exynos5420/usb.c @@ -88,10 +88,11 @@ static void setup_usb_phy(struct usb_phy *usb, int hsic_gpio) udelay(10); clrbits_le32(&usb->hsicphyctrl1, HOST_CTRL0_PHYSWRST);
- /* PHY clock and power setup time */ - // FIXME If this happens more than 50ms before executing the payload, - // we might not need this delay. - mdelay(50); + /* At this point we need to wait for 50ms before talking to + * the USB controller (PHY clock and power setup time) + * By the time we are actually in the payload, these 50ms + * will have passed. + */ }
void usb_init(device_t dev)