build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42224 )
Change subject: soc/amd/common/blocks/gpio: Introduce gpio_get_bar ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42224/1/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42224/1/src/soc/amd/common/block/gp... PS1, Line 158: printk (BIOS_WARNING, "Not programming %s\n", string); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42224/1/src/soc/amd/common/block/gp... PS1, Line 175: const bool can_set_smi_flags = !CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) || !ENV_SEPARATE_VERSTAGE; line over 96 characters