Attention is currently required from: Máté Kukri, Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email )
Change subject: mb/asrock: Add Z87E-ITX (Haswell)
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/asrock/z87e-itx/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/81022/comment/e328788e_3c841b85?usp... :
PS2, Line 20:
I thought Haswell already incorporates HDA verbs for the Mini-HD in chipset code
It does, so no need to add the Mini-HD verbs here. I don't think any of the Haswell boards have them (and if they do, it's probably an oversight while porting).
https://github.com/coreboot/coreboot/blob/f38c9407549b70bf813248c1958d389236...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81022?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586
Gerrit-Change-Number: 81022
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sat, 01 Jun 2024 08:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri
kukri.mate@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com