[coreboot-gerrit] Change in coreboot[master]: [WIP] sb,soc/intel: Consolidate set_acpi_mode()

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41987 )

Change subject: [WIP] sb,soc/intel: Consolidate set_acpi_mode()
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41987/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41987/2//COMMIT_MSG@7 
PS2, Line 7: [WIP] sb,soc/intel: Consolidate set_acpi_mode()
> Currently pretty much nothing builds with HAVE_SMI_HANDLER=n. […]

Well, currently `acpi_disable_sci_on_exit()` is just CONFIG(HAVE_SMI_HANDLER), but comments suggest that it should also evaluate `!acpi_is_wakeup_s3()`. ICH platforms do this:

if (acpi_disable_sci_on_exit()) {
    apm_control(APM_CNT_ACPI_DISABLE);
 } else {
    apm_control(APM_CNT_ACPI_ENABLE);
 }

Whereas PCH platforms onwards do this:

if (acpi_disable_sci_on_exit()) {
    apm_control(APM_CNT_ACPI_DISABLE);
 }

That will be changed if factoring code out, so it would be good to at least mention this change in the commit message.