8 Nov
2022
8 Nov
'22
9:08 a.m.
Attention is currently required from: Werner Zeh.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69307 )
Change subject: mb/siemens/mc_ehl2: Provide I2C timing parameter for SSDT ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69307/comment/37322be2_4b539151 PS1, Line 117: .scl_lcnt = 0x1f4,
I have used hex format to stay consistent with the siemens/mc_apl mainboards. […]
Never mind. It's fine :p
--
To view, visit https://review.coreboot.org/c/coreboot/+/69307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb6019421b612133b8f25c076519bc0e7200dad8
Gerrit-Change-Number: 69307
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 07:08:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: Werner Zeh werner.zeh@siemens.com
Gerrit-MessageType: comment