Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
please limit pictures to 800px in width and try to reduce it's size by using 70% JPEG compression.
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@27
PS3, Line 27: - Mainboard serial number is invalid
does the mainboard have at24rf80 i2c eeprom?
I noticed that the t480 doesn't have one.
https://review.coreboot.org/c/coreboot/+/34359/3/src/mainboard/lenovo/t440p/...
File src/mainboard/lenovo/t440p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34359/3/src/mainboard/lenovo/t440p/...
PS3, Line 1: chip northbridge/intel/haswell # FIXME: check gfx.ndid and gfx.did
remove FIXME
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56a6b94197789a83731d8b349b8ba6814bf57ca2
Gerrit-Change-Number: 34359
Gerrit-PatchSet: 3
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 09:03:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment