[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb

[Jason Glenesk (Code Review)]

Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45340 )

Change subject: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb
......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45340/19/src/soc/amd/picasso/acpi.c 
File src/soc/amd/picasso/acpi.c:

https://review.coreboot.org/c/coreboot/+/45340/19/src/soc/amd/picasso/acpi.c... 
PS19, Line 186: 200 * core_freq_mul) / (core_freq_div
> I understand that it's the same, but probably better to represent it like: […]

In order to do this I would have to use floating arithmetic. Integer division rounding will make the values incorrect. In the Dev Guidelines it prohibits floating arithmetic. Are you ok with leaving this as is? The formula is documented above it in the comment.