Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43358 )
Change subject: cbgfx: Add blend functions to calculate transparency
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43358/3/payloads/libpayload/drivers...
File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/43358/3/payloads/libpayload/drivers...
PS3, Line 188: need_blend ?
: apply_blend(rgb->red, blend.rgb.red) : rgb->red
Doesn't ">>" has higher precedence than "a?b:c", so that […]
https://en.cppreference.com/w/c/language/operator_precedence
Sure, not needed, but since this is a complex statement and is broken down in a rather awkward way, I'd prefer the parentheses to be left in to ease human parsing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43358
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95468f27836d34ab80392727d726a69c09dc168e
Gerrit-Change-Number: 43358
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Ting Shen
phoenixshen@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jul 2020 08:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment