Attention is currently required from: Tarun Tuli, Subrata Banik, Daniel Rosa Franzini, Kapil Porwal, Eric Lai.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74257 )
Change subject: mb/google/rex: add variant gpio tables for variant creation
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/rex/variants/baseboard/rex/gpio.c:
https://review.coreboot.org/c/coreboot/+/74257/comment/f9f96c37_09cef6aa
PS3, Line 32: DECLARE_WEAK_CROS_GPIOS(cros_gpios);
Will it work with an empty array? Because the symbol need to be weak, if I understand it correctly. […]
Yeah empty array should work. Update the change accordingly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebc098f8d480ac3e1835b00861fd844d97f281a8
Gerrit-Change-Number: 74257
Gerrit-PatchSet: 3
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Rosa Franzini
danielt3@usp.br
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Daniel Rosa Franzini
danielt3@usp.br
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 00:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Rosa Franzini
danielt3@usp.br
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment