Attention is currently required from: Eric Lai, Ian Feng, Kenny Pan, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik, Sumeet R Pawnikar.
Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79890?usp=email )
Change subject: mb/google/nissa/var/craaskov: Modify thermal table
......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS5:
I would advice to do things in incremental cls so, it is easy to review the code.
Split fan performance control into CL 79988
File src/mainboard/google/brya/variants/craaskov/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79890/comment/cd13652d_331467c6 :
PS6, Line 189:
blank line?
Split fan performance control into CL 79988
https://review.coreboot.org/c/coreboot/+/79890/comment/f6cf7cc0_3bb0ea47 :
PS6, Line 268:
same?
Split fan performance control into CL 79988
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79890?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15fa4b8f7c7088ff56da6493659ae45572913b5a
Gerrit-Change-Number: 79890
Gerrit-PatchSet: 6
Gerrit-Owner: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kenny Pan
kennypan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kenny Pan
kennypan@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Tue, 16 Jan 2024 07:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment