Attention is currently required from: Felix Singer, Lance Zhao, Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Jeremy Soller, Paul Menzel, Angel Pons, Subrata Banik, Patrick Rudolph. Hello Felix Singer, build bot (Jenkins), Furquan Shaikh, Jeremy Soller, Paul Menzel, Angel Pons, Subrata Banik, Patrick Rudolph, Lance Zhao, Tim Crawford, Nico Huber, Tim Wawrzynczak, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58016
to look at the new patch set (#5).
Change subject: soc/intel: replace dt option PmTimerDisabled by Kconfig ......................................................................
soc/intel: replace dt option PmTimerDisabled by Kconfig
Replace the dt option `PmTimerDisabled` with use of the Kconfig option `USE_PM_ACPI_TIMER` for enabling/disabling the PM Timer.
A default value representing the prior devicetree value was added to the boards system76/{lemp10,galp5,darp7}, so this change will not alter behaviour.
*****
Note: This change is the first of 12 changes that aim to transition full control over the hardware PM Timer and uCode Timer Emulation to coreboot. This series contains the following patches:
* CB:58016 soc/intel: replace dt option PmTimerDisabled by Kconfig * CB:57934 soc/intel/{common,skl}: set ACPI_FADT_PLATFORM_CLOCK based on Kconfig * CB:57931 soc/intel/{common,apl,glk}: guard PM Timer option on SoCs w/o PM Timer * CB:58018 soc/intel/pmc: add a note about legacy OSes/payloads to PM Timer Kconfig * CB:57945 soc/intel/dnv_ns: add the Kconfig value for CPU_XTAL_HZ * CB:57944 soc/intel/dnv_ns: enable uCode PM Timer emulation * CB:58019 soc/intel: move disabling of PM Timer to SoC PMC code * CB:58020 soc/intel: implement ACPI timer disabling per SoC and drop common code * CB:57932 soc/intel/{skl,cnl,dnv,xeon_sp}: disable PM ACPI timer if chosen * CB:57933 soc/intel: transition full control over PM Timer from FSP to coreboot * CB:57930 soc/intel/*: only enable PM Timer emulation if the PM Timer is disabled * CB:58017 soc/intel: drop Kconfig `PM_ACPI_TIMER_OPTIONAL`
*****
Change-Id: If1811c6b98847b22272acfa35ca44f4fbca68947 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/system76/darp7/Kconfig M src/mainboard/system76/darp7/devicetree.cb M src/mainboard/system76/galp5/Kconfig M src/mainboard/system76/galp5/devicetree.cb M src/mainboard/system76/lemp10/Kconfig M src/mainboard/system76/lemp10/devicetree.cb M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/finalize.c M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/elkhartlake/chip.h M src/soc/intel/elkhartlake/finalize.c M src/soc/intel/icelake/Kconfig M src/soc/intel/icelake/chip.h M src/soc/intel/icelake/finalize.c M src/soc/intel/jasperlake/Kconfig M src/soc/intel/jasperlake/chip.h M src/soc/intel/jasperlake/finalize.c M src/soc/intel/tigerlake/Kconfig M src/soc/intel/tigerlake/chip.h M src/soc/intel/tigerlake/finalize.c 21 files changed, 31 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/58016/5