Attention is currently required from: Nick Vaccaro, Karthik Ramasubramanian.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61730 )
Change subject: util/spd_tools/spd_gen/lp5: Encode Optional SDRAM features
......................................................................
Patch Set 1:
(2 comments)
File util/spd_tools/src/spd_gen/lp5.go:
https://review.coreboot.org/c/coreboot/+/61730/comment/16190286_766a1b10
PS1, Line 201: 5
nit: 5:4
https://review.coreboot.org/c/coreboot/+/61730/comment/478f8b81_e3491b8a
PS1, Line 211: 0x40
Shouldn't this be 0x20?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icac8ae148458162768a919d9690d7bf96734e6c0
Gerrit-Change-Number: 61730
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 22:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment