Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37895 )
Change subject: arch/x86: Top align bootblock program
......................................................................
Patch Set 4:
Patch Set 4:
Aaron, ping. Would you want to introduce new (sub)sections such that id.S and fit.S are properly accounted as sections instead of an arbitrary reserve below .reset?
I think that would be helpful. Ideally we can agree on how to construct that upper end for linking purposes w/o wasting space. Basically make the section small enough (w/ an appropriate alignment) to fit the required entries but not large enough that we don't fragment the space leaving it stranded. We can pursue this path soon-ish, but I don't think we're dependent on it at the moment. Let's wait for Marshall to update his patch stack that includes a normal transit through bootblock and romstage for the new boot architecture. Then we can improve things from there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37895
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32518b1c19d08935727330314904b52a246af3c
Gerrit-Change-Number: 37895
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jan 2020 18:22:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment