Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Patrick Rudolph. Timofey Komarov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52692/comment/ba2b4138_ef5eb132 PS1, Line 7: Add Amberlake Kconfig option and some FSP config changes
CB:52704 takes care of the drivers/intel/gma stuff, so this change would only need to touch soc/inte […]
Done
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/b8d0a19d_5e0c6b4c PS1, Line 88: SOC_INTEL_SKYLAKE
Probably better to just change this to SOC_INTEL_COMMON_SKYLAKE_BASE.
This change moved to https://review.coreboot.org/c/coreboot/+/52704/
https://review.coreboot.org/c/coreboot/+/52692/comment/267876d2_fc996e6f PS1, Line 117: SOC_INTEL_SKYLAKE
This too.
This change moved to https://review.coreboot.org/c/coreboot/+/52704/
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/6313fdef_a356b958 PS1, Line 95: default 8
Actually, I think it's better to adjust this in CB:52693 as follows: […]
Done
https://review.coreboot.org/c/coreboot/+/52692/comment/485be9ed_1cb6eab1 PS1, Line 95: default 8
Actually, I think it's better to adjust this in CB:52693 as follows: […]
Done
https://review.coreboot.org/c/coreboot/+/52692/comment/9e29448f_9192fec7 PS1, Line 264: default "3rdparty/fsp/AmberLakeFspBinPkg/Fsp.fd" if SOC_INTEL_AMBERLAKE
I'd prefer to only add a condition for Amber Lake: […]
Done