Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Tim Chu, Yan-tingX Chen.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83610?usp=email )
Change subject: soc/intel/xeon_sp/Kconfig: Disable ANSI escape code
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83610/comment/36296237_b8608a3b?usp... :
PS1, Line 9: To remove ANSI escape sequences (like `ESC [1m`) from boot log.
Using site-local is actually surprisingly simple. […]
I see, thanks all. The intention was just to make the generated logs more readable pasted in code reviews. The site-local way is good. I will cancel this one.
File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/83610/comment/735e774e_70682483?usp... :
PS1, Line 113: config CONSOLE_USE_ANSI_ESCAPES
Unless there is a technical requirement to disable this *for the entire Xeon-SP family*, I would hig […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83610/comment/56c5fc7a_8ca079b0?usp... :
PS1, Line 114: bool "Use ANSI escape sequences for console highlighting"
Repeating the type/prompt is not necessary.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83610?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7473b55d536d3bdfee151e31ecbc52f703b99b17
Gerrit-Change-Number: 83610
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Yan-tingX Chen
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Yan-tingX Chen
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 24 Jul 2024 13:22:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com